Fix for cubic line chart fill when charts that don't start at x-index 0 #711 #712
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t x-index 0 (ChartsOrg#711) Cubic line charts that don’t start at x-index 0 don’t fill correctly because the fill starts at index 0 (Regular line charts don’t have that issue). To correct this the index for the fill is taken from the data entries (similar to regular line chart fill). Ultimately i think the renderer should be refactored to use a common code path for filling cubic and regular line charts.
|
Thank you! About the refactoring suggested - you are right, although I'm not sure how easy this would be... There are more complex issues to solve about cubic paths, like clipping them to straight lines when going below minimum axis... |
|
I understand - yes it might be more complex than i thought. I just felt a little uneasy fixing this issue the way i did. I didn't like the smell of code duplication. |
danielgindi
added a commit
that referenced
this pull request
Feb 23, 2016
Fix for cubic line chart fill when charts that don't start at x-index 0 #711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #711
Cubic line charts that don’t start at x-index 0 don’t fill correctly
because the fill starts at index 0 (Regular line charts don’t have that
issue). To correct this the index for the fill is taken from the data
entries (similar to regular line chart fill).
Ultimately i think the renderer should be refactored to use a common
code path for filling cubic and regular line charts.