Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value of forceLabelsEnabled #360

Merged

Conversation

yas375
Copy link
Contributor

@yas375 yas375 commented Sep 14, 2015

I believe the default value should be false. It's false on Android version of the library. Also I've noticed documentation for isForceLabelsEnabled says it's false by default as well.


Without the fix:
without

With the fix:
with fix

Note that the values on y axis are nicely calculated.

As a temp workaround fix we can do in our code:

self.chartView.leftAxis.labelCount = self.chartView.leftAxis.labelCount;

@danielgindi
Copy link
Collaborator

Thanks :-)

danielgindi added a commit that referenced this pull request Sep 16, 2015
Fix default value of forceLabelsEnabled (=false)
@danielgindi danielgindi merged commit b647053 into ChartsOrg:master Sep 16, 2015
@yas375 yas375 deleted the forceLabelsEnabled-default-value branch September 16, 2015 17:45
@yas375
Copy link
Contributor Author

yas375 commented Sep 16, 2015

@danielgindi thank you for the lib! ;)

Any chance it can be merged into Swift 2.0 branch too? What's current strategy on getting updates to that branch? Do you merge it with master from time to time or should I create a similar pull request with this fix to that branch? Since Xcode 7.0 is now available through AppStore, maybe it makes sense to merge Swift 2.0 branch into master now?

@danielgindi
Copy link
Collaborator

Yes it will be merged very soon into master :-)

Before that I need to go over the diff line by line and make sure that
nothing was broken by mistake.
It's not gonna take more than a day or two!

@yas375
Copy link
Contributor Author

yas375 commented Sep 16, 2015

Awesome! Thanks! ☀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants