Bar chart tests #580
Merged
Bar chart tests #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bar chart tests included mimicking previous line chart tests. Updated ios-snapshot-test-case to 2.0.7 version. Bar chart tests included: - default chart - hide values - hide left axis - hide right axis - hide left axis gridlines - hide right axis gridlines
| override func tearDown() | ||
| { | ||
| // Put teardown code here. This method is called after the invocation of each test method in the class. | ||
| super.tearDown() |
There was a problem hiding this comment.
Nit picking: no need to override tearDown here to just call super. Boiler plate code probably ;)
There was a problem hiding this comment.
You're right @yas375, I just reused the code from the LineChartTests but I will refactor it to a single data generation file and keep the specifics to each of the tests. As well as removing the tearDown override :) thank you
|
Cool! 👍 |
|
Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bar chart tests included mimicking previous line chart tests. Updated
ios-snapshot-test-case to 2.0.7 version.
Bar chart tests include: