[fixed] Double-encoding of URLs

This commit fixes what I was trying to fix in fe5ec39
danieljuhl · Feb 17, 2015 · db2607d · db2607d
1 parent 3457bad
commit db2607d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/modules/locations/HashLocation.js b/modules/locations/HashLocation.js
@@ -95,13 +95,13 @@ var HashLocation = {
 
   push: function (path) {
     _actionType = LocationActions.PUSH;
-    window.location.hash = encodeURI(path);
+    window.location.hash = path;
   },
 
   replace: function (path) {
     _actionType = LocationActions.REPLACE;
     window.location.replace(
-      window.location.pathname + window.location.search + '#' + encodeURI(path)
+      window.location.pathname + window.location.search + '#' + path
     );
   },
 

diff --git a/modules/locations/HistoryLocation.js b/modules/locations/HistoryLocation.js
@@ -65,13 +65,13 @@ var HistoryLocation = {
   },
 
   push: function (path) {
-    window.history.pushState({ path: path }, '', encodeURI(path));
+    window.history.pushState({ path: path }, '', path);
     History.length += 1;
     notifyChange(LocationActions.PUSH);
   },
 
   replace: function (path) {
-    window.history.replaceState({ path: path }, '', encodeURI(path));
+    window.history.replaceState({ path: path }, '', path);
     notifyChange(LocationActions.REPLACE);
   },
 

diff --git a/modules/locations/RefreshLocation.js b/modules/locations/RefreshLocation.js
@@ -9,11 +9,11 @@ var History = require('../History');
 var RefreshLocation = {
 
   push: function (path) {
-    window.location = encodeURI(path);
+    window.location = path;
   },
 
   replace: function (path) {
-    window.location.replace(encodeURI(path));
+    window.location.replace(path);
   },
 
   pop: History.back,