Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF Line Endings #397

Open
kazkansouh opened this issue Mar 16, 2020 · 4 comments
Open

CRLF Line Endings #397

kazkansouh opened this issue Mar 16, 2020 · 4 comments

Comments

@kazkansouh
Copy link
Contributor

Hello.

I have noticed that the line endings in 212 of the 5144 .txt files are CRLF. I guess this is by accident and not intended? I find it can make scripting a little more inconvenient when reading these files as there is one more item to think about.

Usually, the GIT approach would be to rely on core.autocrlf or .gitattributes to manage the translation. That is, store with LF endings, and allow git to add CRLF during checkout when needed, e.g. on Windows.

If its ok, I can submit a simple PR that adds a .gitattributes file (to help standardise future commits) and standardise the existing line endings by running dos2unix on them?

@L1ghtn1ng
Copy link

Would be good to add a .gitattributes file

@g0tmi1k
Copy link
Collaborator

g0tmi1k commented May 27, 2020

Love a PR! <3

@g0tmi1k g0tmi1k self-assigned this May 27, 2020
@g0tmi1k g0tmi1k added the bug Bug label May 27, 2020
@g0tmi1k g0tmi1k removed their assignment Aug 27, 2021
@ItsIgnacioPortal
Copy link
Contributor

ItsIgnacioPortal commented Jun 24, 2022

I find it can make scripting a little more inconvenient when reading these files as there is one more item to think about.

How so? Any half decent library/tool that parses files should already have the capability of seamlessly parsing CRLF or LF endings. If you can point a specific example I think this could be fixed with a CI/CD pipeline using a Github Action.

@molangning
Copy link
Contributor

@g0tmi1k I think this can be closed, also #977 renormalised the line endings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants