Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default syntax highlight colors are bad for light theme #124

Open
DPD85 opened this issue Mar 7, 2024 · 2 comments
Open

Default syntax highlight colors are bad for light theme #124

DPD85 opened this issue Mar 7, 2024 · 2 comments

Comments

@DPD85
Copy link

DPD85 commented Mar 7, 2024

Installed product versions

  • Visual Studio: 2022 Professional, Version 17.9.2
  • This extension: 0.11.170

Description

The default syntax highlight colors are bad with a light theme

Steps to recreate

  1. Set the light of blue theme of Visual Studio;
  2. open a GLSL shader file;
  3. look at the syntax highlight colors of the text.

Current behavior

The actual default syntax highlight colors make the text well readable only when a dark theme is used, so the background color is dark. When, instead, a light theme is used, so the background color is light (for example white), the text will be very hard to read.
See the following picture as an example:

immagine

Expected behavior

The default syntax highlight colors should change accordingly with the used theme or the default colors should be good with light and dark themes (at least with the Visual Studio default themes).

@danielscherzer
Copy link
Owner

Thanks for your feedback! Yes, colors that are sensitive to the theme would be better. I hardcoded them in ClassificationTypes.t4 because I always use a dark theme. So the change would be a bit involved. I also do not know how to query the active Visual Studio theme colors. If you have any knowledge in this area, please feel free to imporve the code. Cheers, Daniel

@DPD85
Copy link
Author

DPD85 commented Mar 8, 2024

Also I don't have any knowledge about this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants