Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geolocation watchPosition parameters seem incorrect #322

Closed
joshgarwood opened this issue Jul 18, 2016 · 4 comments
Closed

Geolocation watchPosition parameters seem incorrect #322

joshgarwood opened this issue Jul 18, 2016 · 4 comments

Comments

@joshgarwood
Copy link

Hi there!

In using the Geolocation.watchPosition() method, it seems as though the ionic-native implementation of this is passing the options in as the second parameter, where the geolocation api is expecting an "onError" function. This results in the following error:

TypeError: Failed to execute 'watchPosition' on 'Geolocation': The callback provided as parameter 2 is not a function.

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 18, 2016

The commit I just pushed should fix that issue.

@joshgarwood
Copy link
Author

Great! Will this be available in a new ionic-native build? Or should I clone the current branch and reference it locally until a new build is released?

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 18, 2016

I'll release a new build now since we have enough updates.

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 18, 2016

Done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants