Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

V5 #97

Open
23 of 25 tasks
danielwerg opened this issue Dec 27, 2022 · 6 comments
Open
23 of 25 tasks

V5 #97

danielwerg opened this issue Dec 27, 2022 · 6 comments
Assignees
Labels
state: breaking A change that requires a major release type: discussion Discussion or question

Comments

@danielwerg
Copy link
Owner

danielwerg commented Dec 27, 2022

  • Naming methods for seasonal stats
  • Document when to use which ubi app id
Done
@danielwerg danielwerg self-assigned this Dec 27, 2022
@danielwerg danielwerg added type: discussion Discussion or question state: breaking A change that requires a major release labels Dec 27, 2022
@danielwerg danielwerg pinned this issue Dec 27, 2022
@danielwerg
Copy link
Owner Author

By "Drop hacky ESM support?" I'm referencing #70 @BadCoder1337 👀

@BadCoder1337
Copy link
Contributor

By "Drop hacky ESM support?" I'm referencing #70 @BadCoder1337 👀

IMHO ESM isn't accepted enough to drop CJS. I am not authoring any npm library so can't give final advice, but think guys from https://github.com/sapphiredev/framework doing well. Their project compiles to CJS and wraps with
https://github.com/addaleax/gen-esm-wrapper to support ESM.

@BadCoder1337
Copy link
Contributor

BadCoder1337 commented Dec 28, 2022

Rename "user" to "profile" where needed in methods

IMHO There's two ways of naming we could stick to:

  1. Keep names close to Ubisoft as possible (e.g. PlatformCrossplay => PlatformFamilies )
  2. Choose different names for consistency and compatibility reasons ? (e.g. unified seasonal info interface. Fetching data before Operation Health - prod.datadev.ubisoft.com, Health to Brutal Swarm - r6karma/players, Solar Raid - r6s/skill/full_profiles)
    There's no major difference between MMR and (rank base RP + displayed RP). If someone is interested in skill they could be obtained through r6karma/players with new crossplay spaceId.

@danielwerg
Copy link
Owner Author

@EndBug I realized I haven't added ts-utils to V5 that you have added while ago in this commit 0d599ac. Could you give me quick ted talk why we need them and how you use them?

@EndBug
Copy link
Collaborator

EndBug commented Jan 13, 2023

@danielwerg If I remember well, I added it because they help when validating user input, when you need to check whether the input is a valid operator, weapon, etc.

@danielwerg
Copy link
Owner Author

Hey @BadCoder1337, I published new repo - R6Data, which is going to be a dependency of next version of R6API.js and I used gen-esm-wrapper for ESM support. Could you test it in your ESM environment and let me know if you have any issue with it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
state: breaking A change that requires a major release type: discussion Discussion or question
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants