Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove c++ internal headers from install if possible #1143

Closed
dankamongmen opened this issue Nov 27, 2020 · 2 comments
Closed

Remove c++ internal headers from install if possible #1143

dankamongmen opened this issue Nov 27, 2020 · 2 comments
Assignees
Labels
C++ c++ wrappers nonfix closed without a successful fix (invalid, wontfix) packaging schlepping up distro packages userquestion not quite bugs--inquiries from users
Milestone

Comments

@dankamongmen
Copy link
Owner

Hey @grendello my man, do we need to be installing internal/Helpers.hh, or the three headers prefixed with _? If so, no worries. If not, let me know and I can pull them out of the install, or you can. Thanks!

-rw-r--r-- root/root       751 2020-11-22 05:22 ./usr/include/ncpp/Utilities.hh
-rw-r--r-- root/root      3505 2020-11-22 05:22 ./usr/include/ncpp/Visual.hh
-rw-r--r-- root/root       855 2020-11-22 05:22 ./usr/include/ncpp/Widget.hh
-rw-r--r-- root/root      1164 2020-11-22 05:22 ./usr/include/ncpp/_exceptions.hh
-rw-r--r-- root/root      2060 2020-11-22 05:22 ./usr/include/ncpp/_flag_enum_operator_helpers.hh
-rw-r--r-- root/root       332 2020-11-22 05:22 ./usr/include/ncpp/_helpers.hh
drwxr-xr-x root/root         0 2020-11-22 05:23 ./usr/include/ncpp/internal/
-rw-r--r-- root/root      1002 2020-11-22 05:22 ./usr/include/ncpp/internal/Helpers.hh
-rw-r--r-- root/root       123 2020-11-22 05:22 ./usr/include/ncpp/ncpp.hh
@dankamongmen dankamongmen added C++ c++ wrappers packaging schlepping up distro packages labels Nov 27, 2020
@dankamongmen dankamongmen added this to the 2.1.0 milestone Nov 27, 2020
@grendello
Copy link
Collaborator

They need to be installed, yes. They are "internal" in the sense that they should not be included directly by the user code as they contain "magic" stuff used by other headers.

@dankamongmen dankamongmen added nonfix closed without a successful fix (invalid, wontfix) userquestion not quite bugs--inquiries from users labels Nov 28, 2020
@dankamongmen
Copy link
Owner Author

Shut her down, boys! Thanks a lot for the explanation (and not making me go look into it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ c++ wrappers nonfix closed without a successful fix (invalid, wontfix) packaging schlepping up distro packages userquestion not quite bugs--inquiries from users
Projects
None yet
Development

No branches or pull requests

2 participants