Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intense flicker with sixel #1454

Closed
dankamongmen opened this issue Mar 24, 2021 · 3 comments · Fixed by #1477
Closed

intense flicker with sixel #1454

dankamongmen opened this issue Mar 24, 2021 · 3 comments · Fixed by #1477
Assignees
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) bug Something isn't working perf sweet sweet perf
Milestone

Comments

@dankamongmen
Copy link
Owner

This kinda goes back to #1391, though we've improved quite a bit since then. Our sixel implementation results in a lot of flicker; this is especially noticeable with ncplayer -bpixel using video, but also in e.g. the yield demo. This just doesn't happen with mplayer -vo sixel (it admittedly does drop frames, but at any play rate, we see flicker, so that's not it).

Figure out exactly what's different between our use of sixel and libsixel's. I don't think this can be blamed on color quantization -- it definitely can't, because low-color videos have the same problem.

This needs be resolved before we can release 2.3.4.

@dankamongmen dankamongmen added bug Something isn't working perf sweet sweet perf bitmaps bitmapped graphics (sixel, kitty, mmap) labels Mar 24, 2021
@dankamongmen dankamongmen added this to the 2.3.0 milestone Mar 24, 2021
@dankamongmen dankamongmen self-assigned this Mar 24, 2021
@dankamongmen
Copy link
Owner Author

we don't see this flicker in our dankamongmen/libsixel branch, even in fullscreen mode. so either it comes down to libsixel's better perf, or something it's doing with its emissions that we are not. but we can absolutely resolve this -- it is within our powers.

@dankamongmen
Copy link
Owner Author

Hrmmm. This seems to be due to sprite_sixel_annihilate(). If it's disabled, we don't get this flicker, or at least tremendously less of it.

@dankamongmen
Copy link
Owner Author

The work going on in #1457 appears to eliminate all this flicker!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) bug Something isn't working perf sweet sweet perf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant