Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async refactor #53

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

async refactor #53

wants to merge 17 commits into from

Conversation

ImLunaHey
Copy link

@ImLunaHey ImLunaHey commented Sep 13, 2023 •
edited
Loading

Closes #49

@ImLunaHey
Copy link
Author

As of e16f728.

CJS Build start
CJS dist/index.js     3.40 KB
CJS dist/index.js.map 15.95 KB
CJS ⚡️ Build success in 178ms
DTS Build start
DTS ⚡️ Build success in 1619ms
DTS dist/index.d.ts 256.00 B

@ImLunaHey
Copy link
Author 

total 80
drwxr-xr-x   8 xo  staff   256B Sep 13 20:13 .
drwxr-xr-x  18 xo  staff   576B Sep 13 20:13 ..
-rw-r--r--   1 xo  staff    96B Sep 13 20:13 block-hash.d.ts
-rw-r--r--   1 xo  staff   6.3K Sep 13 20:13 block-hash.js
-rw-r--r--   1 xo  staff   6.8K Sep 13 20:13 block-hash.js.map
-rw-r--r--   1 xo  staff   337B Sep 13 20:13 index.d.ts
-rw-r--r--   1 xo  staff   5.9K Sep 13 20:13 index.js
-rw-r--r--   1 xo  staff   5.0K Sep 13 20:13 index.js.map

vs

total 48
drwxr-xr-x   5 xo  staff   160B Sep 13 20:11 .
drwxr-xr-x  21 xo  staff   672B Sep 13 20:11 ..
-rw-r--r--   1 xo  staff   256B Sep 13 20:11 index.d.ts
-rw-r--r--   1 xo  staff   3.4K Sep 13 20:11 index.js
-rw-r--r--   1 xo  staff    16K Sep 13 20:11 index.js.map

@ImLunaHey
Copy link
Author

@danm feel free to review. 🙏

ImLunaHey
ImLunaHey commented Sep 13, 2023
View reviewed changes
examples/remote-file.js
@@ -0,0 +1,5 @@
const { imageHash } = require('../dist');

imageHash('https://ichef-1.bbci.co.uk/news/660/cpsprodpb/7F76/production/_95703623_mediaitem95703620.jpg', 16, false).then(res => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really use mocked service worker or something to prevent the need for the actual remote image.

@danm
Copy link
Owner

danm commented Oct 9, 2023

Thank you @ImLunaHey I'll try get to it this week!

@LilyRose2798
Copy link

LilyRose2798 commented Nov 10, 2023 •
edited
Loading

Any updates on getting this merged @danm?

@pawka9
Copy link

pawka9 commented Feb 24, 2024

@danm, any news to this pr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modernise repo
4 participants
@ImLunaHey @danm @LilyRose2798 @pawka9