added asserts to make sure executors are only used in the intended context

Author: firewave

cli/processexecutor.cpp

@@ -32,6 +32,7 @@
 
 #include <algorithm>
 #include <numeric>
+#include <cassert>
 #include <cerrno>
 #include <csignal>
 #include <cstdlib>
@@ -61,7 +62,9 @@ using std::memset;
 
 ProcessExecutor::ProcessExecutor(const std::map<std::string, std::size_t> &files, Settings &settings, ErrorLogger &errorLogger)
     : Executor(files, settings, errorLogger)
-{}
+{
+    assert(mSettings.jobs > 1);
+}
 
 ProcessExecutor::~ProcessExecutor()
 {}

cli/singleexecutor.cpp

@@ -23,6 +23,7 @@
 #include "library.h"
 #include "settings.h"
 
+#include <cassert>
 #include <list>
 #include <numeric>
 #include <utility>
@@ -32,7 +33,9 @@ class ErrorLogger;
 SingleExecutor::SingleExecutor(CppCheck &cppcheck, const std::map<std::string, std::size_t> &files, Settings &settings, ErrorLogger &errorLogger)
     : Executor(files, settings, errorLogger)
     , mCppcheck(cppcheck)
-{}
+{
+    assert(mSettings.jobs == 1);
+}
 
 SingleExecutor::~SingleExecutor()
 {}

cli/threadexecutor.cpp

@@ -26,6 +26,7 @@
 #include "settings.h"
 
 #include <algorithm>
+#include <cassert>
 #include <cstdlib>
 #include <functional>
 #include <future>
@@ -41,7 +42,9 @@ enum class Color;
 
 ThreadExecutor::ThreadExecutor(const std::map<std::string, std::size_t> &files, Settings &settings, ErrorLogger &errorLogger)
     : Executor(files, settings, errorLogger)
-{}
+{
+    assert(mSettings.jobs > 1);
+}
 
 ThreadExecutor::~ThreadExecutor()
 {}