Skip to content

Commit 9827d71

Browse files
committed
fixed some readability-redundant-parentheses clang-tidy warnings
1 parent 34de5be commit 9827d71

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lib/checkcondition.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,7 +1059,7 @@ static bool parseComparison(const Token *comp, bool &not1, std::string &op, std:
10591059
{
10601060
not1 = false;
10611061
while (comp && comp->str() == "!") {
1062-
not1 = !(not1);
1062+
not1 = !not1;
10631063
comp = comp->astOperand1();
10641064
}
10651065

@@ -1096,7 +1096,7 @@ static bool parseComparison(const Token *comp, bool &not1, std::string &op, std:
10961096
expr = comp;
10971097
}
10981098

1099-
inconclusive = inconclusive || ((value)[0] == '\'' && !(op == "!=" || op == "=="));
1099+
inconclusive = inconclusive || (value[0] == '\'' && !(op == "!=" || op == "=="));
11001100

11011101
// Only float and int values are currently handled
11021102
return MathLib::isInt(value) || MathLib::isFloat(value) || (value[0] == '\'');
@@ -1288,13 +1288,13 @@ void CheckCondition::checkIncorrectLogicOperator()
12881288
continue;
12891289

12901290
// the expr are not the token of the value but they provide better context
1291-
const double d1 = (isfloat) ? MathLib::toDoubleNumber(value1) : 0;
1292-
const double d2 = (isfloat) ? MathLib::toDoubleNumber(value2) : 0;
1293-
const MathLib::bigint i1 = (isfloat) ? 0 : MathLib::toBigNumber(value1, expr1);
1294-
const MathLib::bigint i2 = (isfloat) ? 0 : MathLib::toBigNumber(value2, expr2);
1291+
const double d1 = isfloat ? MathLib::toDoubleNumber(value1) : 0;
1292+
const double d2 = isfloat ? MathLib::toDoubleNumber(value2) : 0;
1293+
const MathLib::bigint i1 = isfloat ? 0 : MathLib::toBigNumber(value1, expr1);
1294+
const MathLib::bigint i2 = isfloat ? 0 : MathLib::toBigNumber(value2, expr2);
12951295
const bool useUnsignedInt = (std::numeric_limits<MathLib::bigint>::max()==i1) || (std::numeric_limits<MathLib::bigint>::max()==i2);
1296-
const MathLib::biguint u1 = (useUnsignedInt) ? MathLib::toBigUNumber(value1, expr1) : 0;
1297-
const MathLib::biguint u2 = (useUnsignedInt) ? MathLib::toBigUNumber(value2, expr2) : 0;
1296+
const MathLib::biguint u1 = useUnsignedInt ? MathLib::toBigUNumber(value1, expr1) : 0;
1297+
const MathLib::biguint u2 = useUnsignedInt ? MathLib::toBigUNumber(value2, expr2) : 0;
12981298
// evaluate if expression is always true/false
12991299
bool alwaysTrue = true, alwaysFalse = true;
13001300
bool firstTrue = true, secondTrue = true;

0 commit comments

Comments
 (0)