Fix clang-tidy findings.

* All parameters should be named in a function.
* static member access through instance.

Author: mario-campos

cli/cppcheckexecutor.cpp

@@ -220,7 +220,7 @@ int CppCheckExecutor::check(int argc, const char* const argv[])
     if (settings.xml)
         mReport = std::unique_ptr<AnalysisReport>(new XMLAnalysisReport(settings.cppcheckCfgProductName));
     else if (settings.sarif)
-        mReport = std::unique_ptr<AnalysisReport>(new SARIFAnalysisReport(cppCheck.version()));
+        mReport = std::unique_ptr<AnalysisReport>(new SARIFAnalysisReport(CppCheck::version()));
     else
         mReport = std::unique_ptr<AnalysisReport>(new CLIAnalysisReport(settings.verbose, settings.templateFormat, settings.templateLocation));
 

cli/xmlanalysisreport.h

@@ -29,7 +29,7 @@
  */
 class XMLAnalysisReport : public AnalysisReport {
 public:
-    explicit XMLAnalysisReport(const std::string&);
+    explicit XMLAnalysisReport(const std::string& productName);
     void addFinding(const ErrorMessage &msg) override;
     std::string emit() override;
 private: