Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

GoBackAsync does not trigger OnNavigateTo if using FlyoutPage #239

Open
davibittencourtome opened this issue Sep 15, 2021 · 11 comments
Open

Comments

@davibittencourtome
Copy link

No projeto de amostra, ao navegar a partir do exemplo "FLYOUT PAGE", o GoBackAsync não dispara o OnNavigatedTo da viewModel MainPageViewModel:

https://github.com/dansiegel/Prism.Plugin.Popups/blob/b35e05473e23493b75cdd2ab617fde0300d84ce3/samples/src/PopupPluginSample/ViewModels/PopupViewModel.cs#L52

private async void OnNavigateBackCommandExecuted() { await _navigationService.GoBackAsync(new NavigationParameters{ { "message", "Hello from the Popup View" } }); }

I noticed that when navigating from the example "MASTER DETAIL PAGE" it works normally.

What could it be ? should i configure something specific or would it be a navigation issue with FlyoutPage ?

@dansiegel
Copy link
Owner

Prism 8.0 does NOT support FlyoutPage

@Andreas0xffff
Copy link

We use Prism 8.1 and FlyoutPage is supported by this version.
Corresponding Pull request

Is the problem that FlyoutPage should also be added at this code position?
Prism.Plugin.Popups.Extensions.PageExtensions

@davibittencourtome
Copy link
Author

Exactly @Andreas0xffff , we are using version 8.1.97. We will have to wait for an update with this fix.

@Andreas0xffff
Copy link

@davibittencourtome
Wait for an update of PrismLibrary/Prism (current version 8.1.97) or dansiegel/Prism.Plugin.Popups (current version 8.0.76)?
The Prism.Plugin.Popups alredy references 8.1.97 in its csproj.
I think this issue should be reopened.

@Andreas0xffff
Copy link

@dansiegel
Any news on this?

@davibittencourtome
Copy link
Author

I'm working around with EventAggregator to get around the problem, until a new corrected version comes out

@itoledo
Copy link

itoledo commented Sep 22, 2021

same issue, reverting to MasterDetailPage works.

@dansiegel
Copy link
Owner

This is an open source repo, and I do take PRs. However keep in mind that I am busy with several different libraries and am unlikely to get to this in the next month.

@dansiegel dansiegel reopened this Sep 22, 2021
@markrobert194
Copy link

Any updates on this?

@JaccoDieleman
Copy link

This problem is already solved in the master branch. So we need to do one of the following:

  • Become a sponsor, so we get access to the nuget feed with the pre-release
  • Build and add the nuget package to a private feed ourselves
  • Be patient

@dansiegel
Copy link
Owner

I'd add to your list:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants