Validate Bun Version #227
Validate Bun Version #227
Conversation
danstepanov
commented
Mar 31, 2024
danstepanov
commented
🦋 Changeset detectedLatest commit: 8d52fb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danstepanov
force-pushed
the
enhancement/validate-bun-version
branch
from
e894b7a
to
c6c4ffc
Compare
danstepanov
force-pushed
the
enhancement/validate-bun-version
branch
from
c6c4ffc
to
fcd6b24
Compare
danstepanov
force-pushed
the
enhancement/validate-bun-version
branch
from
fcd6b24
to
e9c59b1
Compare
…n, clean up package manager detection logic, add function to fetch package manager version
danstepanov
force-pushed
the
enhancement/validate-bun-version
branch
from
e9c59b1
to
ca3521a
Compare
| if ( | ||
| cliResults.flags.packageManager === 'bun' && | ||
| defaultPackageManagerVersion && | ||
| defaultPackageManagerVersion !== recommendedBunVersion |
There was a problem hiding this comment.
If the user's default package manager is yarn, is this going to match up after they chose via cli prompt to use bun?
There was a problem hiding this comment.
yea this kinda borks if you choose another package manager, it still reads recommendedBunVersion and says some shit like "bet, we're gonna use yarn v20.x.x" when it actually originally read the version from npm. not sure if that's what you're referring to.
