Chore: Migrate github.com/chai2010/webp to github.com/davidbyttow/govips #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mkalus! I just merged an PR that caused some conflicts with yours. Please resolve the conflicts and I'll review the PR as soon as I can. |
danvergara
added
enhancement
|
Sorry, I have been quite busy lately, I will create a new PR once I find time. |
|
Well, no need to, just fix the conflicts. Want me to do that if you're busy? No problem at all. I just didn't want to step on your toes. |
|
Yes sure - I am drowning in work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
As discussed in #44, I have switched from github.com/chai2010/webp to the "officially" supported library github.com/davidbyttow/govips (supported by libvips that is).
Fixes #44
Type of change
How Has This Been Tested?
Ran the tests images_test and documents_test - works.
Also created Docker image using linux amd64 - since you use debian based Docker images, I do not see any problem creating creating images for other platforms (libvips is in all of those).
Checklist: