Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] The InputDecorator of FormBuilderCheckboxList, FormBuilderRadio, FormBuilderSegmentedControl need to be changed. #160

Closed
lightlitebug opened this issue Oct 28, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@lightlitebug
Copy link

Currently, the InputDecorator of FormBuilderCheckboxList, FormBuilderRadio, and FormBuilderSegmentedControl's border is set to InputBorder.none and contentPadding is set to EdgeInsets.only(top: 10.0, bottom: 0.0).
Because of this, border: OutlineInputBorder() is not working.
For all other widgets, giving border: OutlineInputBorder() work fine.

By changing the packages setting from

return InputDecorator(
  decoration: widget.decoration.copyWith(
     enabled: !_readOnly,
     errorText: field.errorText,
     contentPadding: EdgeInsets.only(top: 10.0, bottom: 0.0),
     border: InputBorder.none,
),

to

return InputDecorator(
  decoration: widget.decoration.copyWith(
    enabled: !_readOnly,
    errorText: field.errorText,
    contentPadding: EdgeInsets.only(top: 10.0, left: 12.0, bottom: 0.0),
),

I could get the desired result.
Why set border to InputBorder.none? Are there any reasons?

This is my screen capture after removing border: InputBorder.none and setting contentPadding: EdgeInsets.only(top: 10.0, left: 12.0, bottom: 0.0).

스크린샷 2019-10-29 오전 12 31 51

I think there is no reason to set border to InputBorder.none.

@lightlitebug lightlitebug changed the title [suggestion] The InputDecorator of FormBuilderCheckboxList, FormBuilderRadio, FormBuilderSegmentedControl 's InputDecorator need to be changed. [suggestion] The InputDecorator of FormBuilderCheckboxList, FormBuilderRadio, FormBuilderSegmentedControl need to be changed. Oct 28, 2019
@danvick danvick added the enhancement New feature or request label Nov 2, 2019
@danvick
Copy link
Collaborator

danvick commented Nov 2, 2019

Hi @lightlitebug,
Your feedback is much appreciated.

@danvick
Copy link
Collaborator

danvick commented Nov 3, 2019

The reason for doing this was simply because I didn't like the spaces created around the fields.
I realize that this may have been ill-advised.

In the next release, I'll have contentPadding and border attributes removed from the library so that the developer decides how that goes.

Cheers!

@lightlitebug
Copy link
Author

lightlitebug commented Nov 3, 2019 via email

@danvick
Copy link
Collaborator

danvick commented Nov 4, 2019

Kindly check out v3.6.0. Let me know if there's anything to add.
Meanwhile, I'm closing this.

Cheers! Thanks for the love.

@danvick danvick closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants