Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: do not bake dygraphs into the tests #1028

Closed
mirabilos opened this issue Oct 20, 2022 · 1 comment
Closed

Idea: do not bake dygraphs into the tests #1028

mirabilos opened this issue Oct 20, 2022 · 1 comment

Comments

@mirabilos
Copy link
Collaborator

What needs to be changed to make tests.js not contain dygraphs itself? (Other than adding the extra <script…></script> tag to also load dygraphs.js to the two HTML files.)

This separation would allow nice things, like running the tests against the minified version as well.

@mirabilos
Copy link
Collaborator Author

This was hard (working around internal design, uhm, decisions in browserify and other tools), but I got it. We now run the tests against the .min.js as well, which I consider a benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant