Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow queuedVoteRequiredPercentage < 50 #75

Open
dOrgJelli opened this issue Jan 10, 2020 · 0 comments
Open

Allow queuedVoteRequiredPercentage < 50 #75

dOrgJelli opened this issue Jan 10, 2020 · 0 comments

Comments

@dOrgJelli
Copy link

Kei from Gnosis was interested in deploying a DAO with a queuedVoteRequiredPercentage = 20, the voting machine configuration is pasted below. It seems strange that the smart contracts would prohibit this, and it should be something that's at the user's discretion to set properly as long as it's >= 1.

Requested code change:
require(_params[0] <= 100 && _params[0] >= 1, "1 <= queuedVoteRequiredPercentage <= 100");

Original Code:
https://github.com/daostack/infra/blob/master/contracts/votingMachines/GenesisProtocolLogic.sol#L259

Config:

{
  "queuedVoteRequiredPercentage": 20,
  "queuedVotePeriodLimit": 604800,
  "thresholdConst": 1001,
  "proposingRepReward": 10,
  "minimumDaoBounty": 0,
  "boostedVotePeriodLimit": 172800,
  "daoBountyConst": 3,
  "activationTime": 0,
  "preBoostedVotePeriodLimit": 43200,
  "quietEndingPeriod": 43200,
  "voteOnBehalf": "0x0000000000000000000000000000000000000000",
  "votersReputationLossRatio": 1
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant