Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DAOToken and Reptuation contract versions to contractInfos #293

Open
jellegerbrandy opened this issue Jul 19, 2019 · 4 comments
Open

Comments

@jellegerbrandy
Copy link
Contributor

the client lib is using the contractInfos collectino to find the ABIs of the contracts, given a contract address.

This works fine, I am happy :-)

But there are two types of contract that we need the ABI for, and which ABI is in migratino.json, but that are not in the contractInfos collection.

These are:

  • The reputation contracts of the DAO
  • The token contracts of the DAO

The client now has the versions of these contracts hardcoded (https://github.com/daostack/client/blob/use-new-redeemer-contract/src/token.ts#L129) which is fine, as long as these contracts do not change. But it would be cleaner to include these in the subgraph index.

@orenyodfat
Copy link
Contributor

what is the reason for the client/alchemy to have these contracts abis ?

@jellegerbrandy
Copy link
Contributor Author

The client library is a library to interact witht he DAOstack contracts and subgraph, and these conracts are part of the stack, and we do stuff like approving, minting, reading different types of data, both in alchemy as well as in the client tests.

@orenyodfat
Copy link
Contributor

though reputation and daotokens contracts are owned by the controller.
any write operations (state change) can not be done directly with these contracts

@jellegerbrandy
Copy link
Contributor Author

Ok, that is interesting but beside the point.

I need the ABI also for reading.

Also, I believe I can transfer my tokens from the DAOToken contract to someone else, which is a state change, and for which I need the ABI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants