Skip to content

Commit 5a33acf

Browse files
binding/mysql: optimize output error (#1195)
* feature/pubsub: add delay queue params for pulsar * feature/pubsub: add delay queue params for pulsar * feature/pubsub: add delay queue params for pulsar * binding/mysql: optimize output error * binding/mysql: optimize output error * Update mysql.go * Update mysql.go Co-authored-by: Simon Leet <31784195+CodeMonkeyLeet@users.noreply.github.com>
1 parent e369fec commit 5a33acf

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

bindings/mysql/mysql.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,14 @@ func (m *Mysql) Invoke(req *bindings.InvokeRequest) (*bindings.InvokeResponse, e
152152
case execOperation:
153153
r, err := m.exec(s)
154154
if err != nil {
155-
return nil, errors.Wrapf(err, "error executing %s with %v", s, err)
155+
return nil, err
156156
}
157157
resp.Metadata[respRowsAffectedKey] = strconv.FormatInt(r, 10)
158158

159159
case queryOperation:
160160
d, err := m.query(s)
161161
if err != nil {
162-
return nil, errors.Wrapf(err, "error executing %s with %v", s, err)
162+
return nil, err
163163
}
164164
resp.Data = d
165165

@@ -193,12 +193,12 @@ func (m *Mysql) Close() error {
193193
return nil
194194
}
195195

196-
func (m *Mysql) query(s string) ([]byte, error) {
197-
m.logger.Debugf("query: %s", s)
196+
func (m *Mysql) query(sql string) ([]byte, error) {
197+
m.logger.Debugf("query: %s", sql)
198198

199-
rows, err := m.db.Query(s)
199+
rows, err := m.db.Query(sql)
200200
if err != nil {
201-
return nil, errors.Wrapf(err, "error executing %s", s)
201+
return nil, errors.Wrapf(err, "error executing %s", sql)
202202
}
203203

204204
defer func() {
@@ -208,7 +208,7 @@ func (m *Mysql) query(s string) ([]byte, error) {
208208

209209
result, err := m.jsonify(rows)
210210
if err != nil {
211-
return nil, errors.Wrapf(err, "error marshalling query result for %s", s)
211+
return nil, errors.Wrapf(err, "error marshalling query result for %s", sql)
212212
}
213213

214214
return result, nil

0 commit comments

Comments
 (0)