Crash from Sentinel issue on arm 32-bit

[kb2ma]

In what area(s)?

/area runtime

What version of Dapr?

1.2.2

Expected Behavior

No crash at startup.

Actual Behavior

dapr v1.2.2 crashes at startup on arm 32-bit due to an integer overflow issue in Sentinel v1.0.2, as I reported upstream, including a stack trace. What's odd is that I have not configured dapr to actually use Sentinel -- no component or configuration yaml.

I have found two ways to workaround the error. First, comment out references to Sentinel in cmd/daprd/main.go. Second, use a version of Sentinel patched for the overflow. See Sentinel patch and use.

Steps to Reproduce the Problem

You should be able to reproduce just by running an app with dapr v1.2.2 on an arm 32-bit platform, like a Raspberry Pi 3.

Release Note

RELEASE NOTE: UPDATE Runtime dependency.

[daixiang0]

Do you have interested to fix it?

[kb2ma]

Do you have interested to fix it?

I would prefer not to work with the upstream Sentinel repository because I have no experience with it and don't need to use it. This work would take time that I really don't have ATM.

It does seem odd that just compiling dapr with the Sentinel plugin present but not configured would cause this issue in dapr. Once again though I don't need to use Sentinel and have a working solution, and unfortunately no time to pursue it.

[yaron2]

/cc @artursouza @wcs1only

[daixiang0]

Seems to need a fix in upstream, just use this patch directly.

[daixiang0]

/assign

@yaron2 if not emergency, will wait for next release of upstream.

[kb2ma]

Not an emergency from my perspective. Thanks for resolving.

[artursouza]

Assigned to @daixiang0

[artursouza]

@daixiang0 Can you test it on an ARM32 bits.

[daixiang0]

@artursouza I am afraid that I can not since no ARM32 machine, just run it within hacked container.

[artursouza]

@daixiang0 No worries. Can you send a PR?

@kb2ma Can you validate this once the fix is in master?

[kb2ma]

@artursouza Sure, I'd be happy to test.

[Oceanswave]

Seems like this was fixed, but is once again breaking on :latest and :edge-linux-arm

goroutine 1 [running]:
github.com/alibaba/sentinel-golang/core/stat/base.NewAtomicBucketWrapArrayWithTime(0x14, 0x1f4, 0x660994d5, 0x17b, 0x314f2b8, 0x51b1f80, 0x51b1f80)
        /home/runner/go/pkg/mod/github.com/alibaba/sentinel-golang@v1.0.2/core/stat/base/leap_array.go:83 +0x334
github.com/alibaba/sentinel-golang/core/stat/base.NewAtomicBucketWrapArray(0x14, 0x1f4, 0x314f2b8, 0x51b1f80, 0x0)
        /home/runner/go/pkg/mod/github.com/alibaba/sentinel-golang@v1.0.2/core/stat/base/leap_array.go:108 +0x48
github.com/alibaba/sentinel-golang/core/stat/base.NewBucketLeapArray(0x14, 0x2710, 0xb6f1ccb8)
        /home/runner/go/pkg/mod/github.com/alibaba/sentinel-golang@v1.0.2/core/stat/base/bucket_leap_array.go:60 +0x84
github.com/alibaba/sentinel-golang/core/stat.NewBaseStatNode(0x2, 0x3e8, 0x4ed0d74)
        /home/runner/go/pkg/mod/github.com/alibaba/sentinel-golang@v1.0.2/core/stat/base_node.go:36 +0x30
github.com/alibaba/sentinel-golang/core/stat.NewResourceNode(0x2bc34cb, 0x19, 0x0, 0x1c920)
        /home/runner/go/pkg/mod/github.com/alibaba/sentinel-golang@v1.0.2/core/stat/resource_node.go:32 +0x34
github.com/alibaba/sentinel-golang/core/stat.init()
        /home/runner/go/pkg/mod/github.com/alibaba/sentinel-golang@v1.0.2/core/stat/node_storage.go:27 +0x2c

[artursouza]

@daixiang0 Can this be fixed again and validated as part of the build? I see that we are skipping running tests in arm32.

[artursouza]

@kb2ma Please, validate the current master version.