Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv disjoint endpoint field to built-in aws auth profile metadata #3622

Closed
sicoyle opened this issue Dec 4, 2024 · 3 comments
Closed

mv disjoint endpoint field to built-in aws auth profile metadata #3622

sicoyle opened this issue Dec 4, 2024 · 3 comments
Labels
kind/enhancement New feature or request stale

Comments

@sicoyle
Copy link
Contributor

sicoyle commented Dec 4, 2024

Describe the feature

The Dapr docs show endpoint as an optional field.
image

It is included in some of the AWS components, but not all. It should be moved to be part of the built-in aws auth profile fields here: https://github.com/dapr/components-contrib/blob/main/.build-tools/builtin-authentication-profiles.yaml and something that can be optionally added for all aws components.

This would be a good first time issue. Please, someone add that label.

Release Note

RELEASE NOTE:

@sicoyle sicoyle added the kind/enhancement New feature or request label Dec 4, 2024
@sicoyle
Copy link
Contributor Author

sicoyle commented Dec 4, 2024

looks like it's only used by these aws components atm: s3, dynamodb, kinesis, secretmanager, snssqs

https://github.com/search?q=repo%3Adapr%2Fcomponents-contrib%20name%3A%20endpoint&type=code

Copy link

github-actions bot commented Jan 3, 2025

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 3, 2025
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant