Skip to content

Commit bd84b7d

Browse files
committed
chore: Fix review comments
Signed-off-by: Javier Aliaga <javier@diagrid.io>
1 parent 714b787 commit bd84b7d

File tree

4 files changed

+31
-29
lines changed

4 files changed

+31
-29
lines changed

examples/src/main/java/io/dapr/examples/workflows/crossapp/App2TransformActivity.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,14 @@
2121
* This activity is called cross-app from the main workflow.
2222
*/
2323
public class App2TransformActivity implements WorkflowActivity {
24-
@Override
25-
public Object run(WorkflowActivityContext context) {
26-
String input = context.getInput(String.class);
27-
System.out.println("=== App2: TransformActivity called ===");
28-
System.out.println("Input: " + input);
29-
String result = input.toUpperCase() + " [TRANSFORMED BY APP2]";
30-
System.out.println("Output: " + result);
31-
return result;
32-
}
24+
@Override
25+
public Object run(WorkflowActivityContext context) {
26+
String input = context.getInput(String.class);
27+
var logger = context.getLogger();
28+
logger.info("=== App2: TransformActivity called ===");
29+
logger.info("Input: {}", input);
30+
String result = input.toUpperCase() + " [TRANSFORMED BY APP2]";
31+
logger.info("Output: {}", result);
32+
return result;
33+
}
3334
}

examples/src/main/java/io/dapr/examples/workflows/crossapp/App3FinalizeActivity.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,11 @@ public class App3FinalizeActivity implements WorkflowActivity {
2424
@Override
2525
public Object run(WorkflowActivityContext context) {
2626
String input = context.getInput(String.class);
27-
System.out.println("=== App3: FinalizeActivity called ===");
28-
System.out.println("Input: " + input);
27+
var logger = context.getLogger();
28+
logger.info("=== App3: FinalizeActivity called ===");
29+
logger.info("Input: {}", input);
2930
String result = input + " [FINALIZED BY APP3]";
30-
System.out.println("Output: " + result);
31+
logger.info("Output: {}", result);
3132
return result;
3233
}
3334
}

examples/src/main/java/io/dapr/examples/workflows/crossapp/CrossAppWorkflow.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,19 @@ public class CrossAppWorkflow implements Workflow {
2525
@Override
2626
public WorkflowStub create() {
2727
return ctx -> {
28-
ctx.getLogger().info("=== WORKFLOW STARTING ===");
29-
ctx.getLogger().info("Starting CrossAppWorkflow: " + ctx.getName());
30-
ctx.getLogger().info("Workflow name: " + ctx.getName());
31-
ctx.getLogger().info("Workflow instance ID: " + ctx.getInstanceId());
28+
var logger = ctx.getLogger();
29+
logger.info("=== WORKFLOW STARTING ===");
30+
logger.info("Starting CrossAppWorkflow: {}", ctx.getName());
31+
logger.info("Workflow name: {}", ctx.getName());
32+
logger.info("Workflow instance ID: {}", ctx.getInstanceId());
3233

3334
String input = ctx.getInput(String.class);
34-
ctx.getLogger().info("CrossAppWorkflow received input: " + input);
35-
ctx.getLogger().info("Workflow input: " + input);
35+
logger.info("CrossAppWorkflow received input: {}", input);
36+
logger.info("Workflow input: {}", input);
3637

3738
// Call an activity in another app by passing in an active appID to the WorkflowTaskOptions
38-
ctx.getLogger().info("Calling cross-app activity in 'app2'...");
39-
ctx.getLogger().info("About to call cross-app activity in app2...");
39+
logger.info("Calling cross-app activity in 'app2'...");
40+
logger.info("About to call cross-app activity in app2...");
4041
String crossAppResult = ctx.callActivity(
4142
App2TransformActivity.class.getName(),
4243
input,
@@ -45,19 +46,18 @@ public WorkflowStub create() {
4546
).await();
4647

4748
// Call another activity in a different app
48-
ctx.getLogger().info("Calling cross-app activity in 'app3'...");
49-
ctx.getLogger().info("About to call cross-app activity in app3...");
49+
logger.info("Calling cross-app activity in 'app3'...");
50+
logger.info("About to call cross-app activity in app3...");
5051
String finalResult = ctx.callActivity(
5152
App3FinalizeActivity.class.getName(),
5253
crossAppResult,
5354
new WorkflowTaskOptions("app3"),
5455
String.class
5556
).await();
56-
ctx.getLogger().info("Final cross-app activity result: " + finalResult);
57-
ctx.getLogger().info("Final cross-app activity result: " + finalResult);
58-
59-
ctx.getLogger().info("CrossAppWorkflow finished with: " + finalResult);
60-
ctx.getLogger().info("=== WORKFLOW COMPLETING WITH: " + finalResult + " ===");
57+
logger.info("Final cross-app activity result: {}", finalResult);
58+
59+
logger.info("CrossAppWorkflow finished with: {}", finalResult);
60+
logger.info("=== WORKFLOW COMPLETING WITH: {} ===", finalResult);
6161
ctx.complete(finalResult);
6262
};
6363
}

sdk-autogen/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<protobuf.input.directory>${project.build.directory}/proto</protobuf.input.directory>
2323
<maven.deploy.skip>false</maven.deploy.skip>
2424
<grpc.version>1.69.0</grpc.version>
25-
<protocCommand>protoc</protocCommand>
25+
<protocCommand>java-sdk-protoc</protocCommand>
2626
<protobuf.version>3.25.5</protobuf.version>
2727
</properties>
2828

@@ -132,7 +132,7 @@
132132
<goal>run</goal>
133133
</goals>
134134
<configuration>
135-
<protocCommand>protoc</protocCommand>
135+
<protocCommand>java-sdk-protoc</protocCommand>
136136
<protocVersion>${protobuf.version}</protocVersion>
137137
<protocArtifact>com.google.protobuf:protoc:3.25.5</protocArtifact>
138138
<addProtoSources>inputs</addProtoSources>

0 commit comments

Comments
 (0)