Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned Channels #1002

Closed
cicoyle opened this issue Feb 5, 2024 · 2 comments
Closed

Orphaned Channels #1002

cicoyle opened this issue Feb 5, 2024 · 2 comments
Labels
kind/bug Something isn't working

Comments

@cicoyle
Copy link
Contributor

cicoyle commented Feb 5, 2024

Expected Behavior

I would expect to be able to run ./mvnw -B test -q in CI & locally without seeing a bunch of managed orphan channels not being shutdown properly. I would have thought these orphaned channels should fail the build, but in CI it is successful even with an orphaned channel.

Actual Behavior

There are several orphaned channels in the existing code.

io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue
SEVERE: *~*~*~ Previous channel ManagedChannelImpl{logId=37, target=directaddress:///9b8b79eb-09f7-483c-8801-ac1c9c047f62} was not shutdown properly!!! ~*~*~*
    Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.
java.lang.RuntimeException: ManagedChannel allocation site

This muddy's the output, and can lead to confusion about what issue is a result of new code. I myself fell victim to seeing this issue and thinking it was due to my recently added code, only to find out that there are many orphaned channels from existing code.

Steps to Reproduce the Problem

Run: ./mvnw -B test -q locally & look at our CI, example here.

@cicoyle cicoyle added the kind/bug Something isn't working label Feb 5, 2024
@cicoyle
Copy link
Contributor Author

cicoyle commented Feb 5, 2024

I have 3 PRs to fix the orphaned channels in the following tests, there are still more!!

@mukundansundar
Copy link
Contributor

another PR fixing NetworkUtilsTest #1007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants