Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unsubscribe API for Configuration building block #698

Closed
mukundansundar opened this issue Feb 28, 2022 · 5 comments · Fixed by #740
Closed

Add Unsubscribe API for Configuration building block #698

mukundansundar opened this issue Feb 28, 2022 · 5 comments · Fixed by #740
Assignees
Labels
breaking-change kind/enhancement New feature or request kind/enhancement-runtime-dependency New feature or request due to a runtime feature P1
Milestone

Comments

@mukundansundar
Copy link
Contributor

mukundansundar commented Feb 28, 2022

dapr/dapr#4130 changes proto files to add unsubscribe API as well as additional fields to existing configuration API response.

Implement the unsubscribe API as well as add in the additional fields necessary for the change to include ID field in subscribe API to track for stopping subscription.

Release Note

RELEASE NOTE: Add unsubscribe API.

@mukundansundar mukundansundar added kind/bug Something isn't working P1 labels Feb 28, 2022
@mukundansundar mukundansundar added this to the v1.5 milestone Feb 28, 2022
@mukundansundar
Copy link
Contributor Author

@artursouza

@mukundansundar mukundansundar changed the title Fix broken Configuration API subscribeToConfiguration Fix unused Configuration API fields Mar 15, 2022
@pravinpushkar
Copy link
Contributor

/assign

@pravinpushkar
Copy link
Contributor

@mukundansundar Verified this with dapr master and proto file, it works fine. There is no change needed at Java-sdk level.

We can close this issue.

@mukundansundar
Copy link
Contributor Author

@pravinpushkar Interesting ... We are not using the full SubscribeConfigurationResponse anywhere ... Which is kind of expected since it only contained List till the above PR.
Now it has an ID field too ... which is used for unsubscribe API.

I will keep this issue open and change the title to implement unsubscribe API. Then we would need the proto changes that were made in dapr/dapr. https://github.com/dapr/dapr/pull/4130/files#diff-da511bac0105b1e517ff78c6351b68bda0d5862cb0daae89127f6c0250551265R528

@mukundansundar mukundansundar changed the title Fix unused Configuration API fields Add Unsubscribe API for Configuration building block Mar 18, 2022
@mukundansundar mukundansundar added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Mar 18, 2022
@mukundansundar mukundansundar modified the milestones: v1.5, v1.6 Mar 18, 2022
@mukundansundar
Copy link
Contributor Author

I have added a breaking changes label since I believe the exposed API in the preview client will change to include the SubscribeConfigurationResponse.

@pravinpushkar pravinpushkar moved this to In Progress in v1.8 Tracking board May 10, 2022
@msfussell msfussell added the kind/enhancement-runtime-dependency New feature or request due to a runtime feature label Jun 8, 2022
@artursouza artursouza modified the milestones: v1.6, v1.7 Jun 23, 2022
Repository owner moved this from In Progress to Done in v1.8 Tracking board Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change kind/enhancement New feature or request kind/enhancement-runtime-dependency New feature or request due to a runtime feature P1
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants