-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unsubscribe API for Configuration building block #698
Comments
/assign |
@mukundansundar Verified this with dapr master and proto file, it works fine. There is no change needed at Java-sdk level. We can close this issue. |
@pravinpushkar Interesting ... We are not using the full SubscribeConfigurationResponse anywhere ... Which is kind of expected since it only contained List till the above PR. I will keep this issue open and change the title to implement unsubscribe API. Then we would need the proto changes that were made in dapr/dapr. https://github.com/dapr/dapr/pull/4130/files#diff-da511bac0105b1e517ff78c6351b68bda0d5862cb0daae89127f6c0250551265R528 |
I have added a breaking changes label since I believe the exposed API in the preview client will change to include the SubscribeConfigurationResponse. |
dapr/dapr#4130 changes proto files to add unsubscribe API as well as additional fields to existing configuration API response.
Implement the unsubscribe API as well as add in the additional fields necessary for the change to include ID field in subscribe API to track for stopping subscription.
Release Note
RELEASE NOTE: Add unsubscribe API.
The text was updated successfully, but these errors were encountered: