You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today we find multiple instances of these in our codebase:
asyncsubscribe(_storeName: string,_cb: SubscribeConfigurationCallback): Promise<SubscribeConfigurationStream>{thrownewError('HTTP is currently not supported.');}getRegisteredActors(): Promise<string[]>{thrownewError('GRPC is currently not supported.');}
This proposal is to create two custom Errors: HttpNotSupportedError and GrpcNotSupportedError which can be reused in our code.
The text was updated successfully, but these errors were encountered:
Hello @shubham1172
I'm new to contributing to open source, i came across this project after a while of searching and i would love to take on this issue. could you give me any pointers on how to go about it?? what file would i have to modify or what folder to create a new file for the custom error.
Thank you and kind regards.
I would probably add a new errors dir here https://github.com/dapr/js-sdk/tree/main/src/types and create custom error classes, and then replace HTTP/gRPC is not supported errors in the codebase with these types. Please feel free to create a draft PR and then we can discuss more implementation details there.
Describe the proposal
Today we find multiple instances of these in our codebase:
This proposal is to create two custom Errors:
HttpNotSupportedError
andGrpcNotSupportedError
which can be reused in our code.The text was updated successfully, but these errors were encountered: