Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hello kubernetes examples (nodeapp and pythonapp) are not using the SDKs #1029

Closed
salaboy opened this issue Jun 6, 2024 · 0 comments · Fixed by #1030
Closed

hello kubernetes examples (nodeapp and pythonapp) are not using the SDKs #1029

salaboy opened this issue Jun 6, 2024 · 0 comments · Fixed by #1030

Comments

@salaboy
Copy link
Contributor

salaboy commented Jun 6, 2024

Describe the feature

The examples nodeapp and pythonapp doesn't use the Dapr SDKs and just do plain HTTP calls.
The DAPR host is hardcoded in both applications to be localhost which limit this examples to be used only when daprd is injected as a sidecar.

Supporting setting the host via the environment variable: DAPR_HTTP_ENDPOINT will align with how SDKs can set up remote hosts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating hello-kubernetes quickstart to support Endpoint env vars salaboy/quickstarts
1 participant
@salaboy