Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the Zipkin observability tutorial #1031

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

pdebruin
Copy link
Contributor

Description

Please explain the changes you've made
Based on #932 I have made minor issues to the observability tutorial.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]
#932

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Pieter de Bruin <pdebruin@hotmail.com>
@pdebruin
Copy link
Contributor Author

For completeness, I successfully ran through the tutorial with Dapr 1.13 on Kubernetes.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdebruin Thanks for this contribution!

@msfussell msfussell merged commit f695e1b into dapr:master Jul 26, 2024
3 checks passed
@msfussell msfussell added this to the 1.14 milestone Jul 26, 2024
@marcduiker
Copy link
Contributor

@holopin-bot @pdebruin Thanks Pieter!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @pdebruin, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbmcr5231740cjvadz4v3sb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants