-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerize C# Pubsub Quickstart #1045
base: release-1.14
Are you sure you want to change the base?
Conversation
Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
This is cool @marcduiker. Can we think about how these images get published? I think we'd want them to go to ghcr.io like tutorials/hello-kubernetes images so you can simply apply on kubernetes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we please consider building and pushing this to ghcr, and applying with images from ghcr? please see tutorials/hello-kubernetes. happy to discuss
Also @marcduiker - C# has built in support to create dockerfiles and kubernetes files as an output of dotnet publish. any chance you could explore this? It will keep it cleaner and still accomplish the scenario, the C# way.
|
Oh, this is nice, yes I'll check this. |
Description
This is a work-in-progress
Added Dockerfiles and deployment files to run the C# Pubsub QS on Kubernetes.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1046
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: