You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<ddclass="field-odd"><p><codeclass="docutils literal notranslate"><spanclass="pre">True</span></code> if the input has just gone from not zero to 0. Best to use only with boolean values (binary PVs).</p>
FWIW, the comment in the code is correct.
Same applies to the docs of the fsmIO.rising().
The text was updated successfully, but these errors were encountered:
You are right, the documentation is correct only in the context of binary input or output PVs that have only 0 or 1 values. I would keep the method as-is but specify better its behaviour in the docs.
The behavior of the
fsmIO.falling()
as documented is not matching what the code does:pysmlib/smlib/io.py
Line 379 in 96ddde2
The
fsmIO.falling()
will beTrue
as soon as the value of the PV is less than previous value, and not when value is 0 as per docs:pysmlib/docs/docs/html/io.html
Line 487 in 96ddde2
FWIW, the comment in the code is correct.
Same applies to the docs of the
fsmIO.rising()
.The text was updated successfully, but these errors were encountered: