Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizable cookie groups #216

Open
1 of 2 tasks
agracia-foticos opened this issue Jun 12, 2024 · 8 comments
Open
1 of 2 tasks

feat: customizable cookie groups #216

agracia-foticos opened this issue Jun 12, 2024 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@agracia-foticos
Copy link

agracia-foticos commented Jun 12, 2024

Describe the feature

There is two types of cookies:

necessary and optional.

Please allow add new group custom cookies.

In a lot of websites, the cookies are grouped like "necesary", "ads", "analytics", "geo", etc... not only 2 "static" group of cookies (necesary and optional)

Additional information

  • Would you be willing to help implement this feature?

Final checks

@dargmuesli dargmuesli added the help wanted Extra attention is needed label Jun 12, 2024
@dargmuesli
Copy link
Owner

PRs welcome!

@agracia-foticos
Copy link
Author

here you are an example of other consent banner cookies with custom categories
https://cookieconsent.orestbida.com/reference/configuration-reference.html#categories

@agracia-foticos
Copy link
Author

Or maybe extend, not only optional and necessary.
Extend to

  • Necessary
  • Functionality
  • Analytics
  • Marketing

@agracia-foticos
Copy link
Author

image
Extend in this enum to :

export declare enum CookieType {
NECESSARY = "necessary",
FUNCTIONALITY = "functionality",
ANALYTICS = "analytics",
MARKETING = "marketing"
}

@dargmuesli
Copy link
Owner

I think the categories should be configurable eventually, as configurability is a goal of this project.

@agracia-foticos
Copy link
Author

I think the categories should be configurable eventually, as configurability is a goal of this project.

@dargmuesli
Do you know when you will implement this configurability?

@dargmuesli
Copy link
Owner

Yes, I won't implement this feature myself, that's why I wrote "PR welcome" and tagged this issue with the "help wanted" label.

@agracia-foticos
Copy link
Author

@dargmuesli
I create new pull request to fix this issue

@dargmuesli dargmuesli changed the title Add new cookies group feat: customizable cookie groups Jun 23, 2024
@dargmuesli dargmuesli added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants