Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generation of routers based on Partitions for Stateless services #12

Open
Mahons opened this issue Nov 6, 2021 · 4 comments
Open
Assignees

Comments

@Mahons
Copy link
Contributor

Mahons commented Nov 6, 2021

I'd like to make the auto-generation of services based on partitions optional (or potenially disable it altogether) for Stateless services.

@dariopb

According to the Microsoft documentation:

"partitioning a stateless service is a very rare scenario--scalability and availability are normally achieved by adding more instances."

At the moment, I'm creating services with custom routers and the auto-generated routers are noisy in my configuration and something I will never use.

I'm happy to create a PR, however, @dariopb, as you're the owner, I'd like to discuss it with you first.

@dariopb
Copy link
Owner

dariopb commented Nov 17, 2021

I agree, we should define either a plugin-wide config parameter that controls the auto partition route behavior (like, generate all partition routes or only the first one) or could be a specific label that controls it per service.

@Mahons
Copy link
Contributor Author

Mahons commented Nov 17, 2021

I think it's okay to leave it as is for stateful services, i.e., generate a route for each partition. However, for stateless, I'd be inclined to turn it off globally and provide a label to turn it on as required. I won't get a chance this week but will try get something together over the following week.

Do you want to assign this issue to me?

@dariopb
Copy link
Owner

dariopb commented Nov 19, 2021

@Mahons, would you like me to generate a new release with all the changes or are you using the plugin with via the local plugin way?

@Mahons
Copy link
Contributor Author

Mahons commented Nov 19, 2021

@dariopb No harm creating a release; I'm using it via the localPlugin configuration, but there may be others who are using it via the pilot website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants