Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap: Timeout peers who have not respond #211

Open
dariusc93 opened this issue May 10, 2024 · 0 comments
Open

bitswap: Timeout peers who have not respond #211

dariusc93 opened this issue May 10, 2024 · 0 comments
Labels
enhancement New feature or request p:normal Normal Priority

Comments

@dariusc93
Copy link
Owner

Currently, we would send a message with sendDontHave being true, however not all bitswap implementations would act on this field or may ignore it causing us to wait as a result. What we should do instead is add a timeout to each peer when we send a request and if a message does not arrive before it timeout then we should pop the peer from the session or move them into a separate queue to be removed so when the session is polled again we can send a cancel request as we remove them, but if they respond before this happen, we could move them back into the session.

@dariusc93 dariusc93 added enhancement New feature or request p:normal Normal Priority labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p:normal Normal Priority
Projects
None yet
Development

No branches or pull requests

1 participant