Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting 500 on big user, unclear why #3710

Closed
Tracked by #3690
pbiggar opened this issue Apr 16, 2022 · 5 comments
Closed
Tracked by #3690

getting 500 on big user, unclear why #3710

pbiggar opened this issue Apr 16, 2022 · 5 comments

Comments

@pbiggar
Copy link
Member

pbiggar commented Apr 16, 2022

Debugging this issue now.

@pbiggar
Copy link
Member Author

pbiggar commented Apr 16, 2022

So far I've found two issues:

Issue 1:

calling a function like this:

value
|> myFunction dErrorValue dErrorValue

in OCaml returns dErrorValue but in F# returns a DIncomplete.

No obvious cause so far.

Issue 2:

F# DB::keys is returning [] while OCaml DB::keys is returning ["some value"] (OCaml seems to be correct here).

The DB contents are set in the background every minute, by getting the response, adding a new value, then deleting the old values one-by-one (note this is using OCaml code in the queueworker).

I don't have any obvious leads.

@pbiggar
Copy link
Member Author

pbiggar commented Apr 17, 2022

Not having any success reproducing this locally. My plan is to deploy an instrumented version of the runtime to make just this request and see what I can learn.

@pbiggar
Copy link
Member Author

pbiggar commented Apr 19, 2022

OK, found issue 1. The user named their function myfunction_v1, and we parsed that as a StdLib and not as a UserFunction. This means that the function didn't exist, and we returned an Incomplete.

  1. needs tests
  2. probably if they don't have a module we should check the stdlib before we decide it's a stdlib function
  3. these are probably saved in the DB like this so some sort of migration or fix is required
  4. for the millionth time, returning an incomplete here sucks; an error would have been far better

@StachuDotNet
Copy link
Member

relates to #3641, it seems

@pbiggar
Copy link
Member Author

pbiggar commented Apr 21, 2022

Fixed and followup done.

@pbiggar pbiggar closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants