Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-cms missing styles #259

Open
benjaoming opened this issue Jul 27, 2014 · 4 comments
Open

django-cms missing styles #259

benjaoming opened this issue Jul 27, 2014 · 4 comments

Comments

@benjaoming
Copy link
Contributor

The "add subpage" and delete icons are missing. And the "Add page" in .object-tools is also missing.

Example:

screenshot from 2014-07-27 22 19 37

How it looks without suit:

screenshot from 2014-07-27 22 18 57

I would suggest looking at the following... but maybe it could use some of the django-suit icons... sorry that I don't have time to dig into your less compiling stuff... but hope this can maybe help....

#sitemap li a.addlink {
    padding-left: 12px;
    background: url('../img/icon_addlink.gif') no-repeat scroll 0px 0.2em transparent;
}

#sitemap li a.deletelink {
    padding-left: 12px;
    background: url('../img/icon_deletelink.gif') no-repeat scroll 0px 0.25em transparent;
}

.object-tools li a.addlink
{
    .btn();
    .btn-success();
}
@darklow
Copy link
Owner

darklow commented Aug 14, 2014

Please read my comment regarding newest django-cms and support for it:
#213 (comment)

@benjaoming
Copy link
Contributor Author

@darklow I don't think you're far from the goal!! I use django-cms 3 every day together with suit, and it's just those buttons missing.

The rest, we've fixed upstream.

I beg you, please use a couple of minutes to get the missing buttons back, and I think the support level is absolutely reasonable :)

Not supporting django-cms3 for the BS3 is perfectly understandable, but at the same time, I think there's a probability that you'll get a PR for it.

@darklow
Copy link
Owner

darklow commented Aug 14, 2014

By looking at your screenshot and the screenshot it was with 2.x cms version i would say i am pretty far from expected results - look at the screenshot here:
#77 (comment)

@benjaoming
Copy link
Contributor Author

@darklow well, it's a matter of fixing the critical missing icons :) what i meant was that the rest of critical issues have been fixed.

Also, I think that actually django-cms 3 changed the columns of the Page change list.

If you have basic support, you can leave the polishing to the community perhaps? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants