fix: prefer-extracting-callbacks in nested widgets (#639)

Author: ookami-kb

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 * feat: support excludes for a separate anti-pattern.
+* fix: prefer-extracting-callbacks in nested widgets
 
 ## 4.9.0
 

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/visitor.dart

@@ -34,6 +34,8 @@ class _InstanceCreationVisitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitInstanceCreationExpression(InstanceCreationExpression node) {
+    super.visitInstanceCreationExpression(node);
+
     for (final argument in node.argumentList.arguments) {
       final expression =
           argument is NamedExpression ? argument.expression : argument;

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/examples/example.dart

@@ -88,6 +88,21 @@ class MyWidgetWithEmptyCallbacks extends StatelessWidget {
   }
 }
 
+class MyWidgetWithNestedWidget extends StatelessWidget {
+  @override
+  Widget build(BuildContext context) {
+    return Container(
+      child: TextButton(
+        // LINT
+        onPressed: () {
+          return null;
+        },
+        child: Container(),
+      ),
+    );
+  }
+}
+
 class Widget {}
 
 class StatelessWidget extends Widget {}

test/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks_rule_test.dart

@@ -25,19 +25,23 @@ void main() {
 
       RuleTestHelper.verifyIssues(
         issues: issues,
-        startLines: [11, 55],
-        startColumns: [7, 7],
+        startLines: [11, 55, 97],
+        startColumns: [7, 7, 9],
         locationTexts: [
           'onPressed: () {\n'
               '        return null;\n'
               '      }',
           'onPressed: () {\n'
               '        return null;\n'
               '      }',
+          'onPressed: () {\n'
+              '          return null;\n'
+              '        }',
         ],
         messages: [
           'Prefer extracting the callback to a separate widget method.',
           'Prefer extracting the callback to a separate widget method.',
+          'Prefer extracting the callback to a separate widget method.',
         ],
       );
     });