Skip to content

Commit 089e328

Browse files
committed
Move implementation to build_runner_core.
1 parent e1264f4 commit 089e328

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+102
-84
lines changed

build/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
## 3.0.3-wip
22

3+
- Deprecate `runBuilder`. It has been moved to `package:build_runner_core` and
4+
will be deleted from `package:build`. Please note: the currently supported
5+
ways to run builders are using `build_runner` on the command line or
6+
`build_test` in tests. If you need ongoing support for a different way to run
7+
builders please get in touch at
8+
https://github.com/dart-lang/build/discussions.
39
- Use `build_runner_core` 9.3.1.
410

511
## 3.0.2

build/lib/src/generate/run_builder.dart

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,15 @@ import '../builder/build_step.dart';
1616
import '../builder/builder.dart';
1717
import '../resource/resource.dart';
1818

19-
@Deprecated('oh no')
19+
@Deprecated('''
20+
This method has moved to `package:build_runner_core` and will be
21+
deleted from `package:build`.
22+
23+
The currently supported ways to run builders are using `build_runner`
24+
on the command line or `build_test` in tests. If you need ongoing
25+
support for a different way to run builders please get in touch at
26+
https://github.com/dart-lang/build/discussions.
27+
''')
2028
Future<void> runBuilder(
2129
Builder builder,
2230
Iterable<AssetId> inputs,

build/lib/src/internal.dart

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,3 @@
77
library;
88

99
export 'builder/logging.dart';
10-
export 'library_cycle_graph/asset_deps.dart';
11-
export 'library_cycle_graph/asset_deps_loader.dart';
12-
export 'library_cycle_graph/library_cycle.dart';
13-
export 'library_cycle_graph/library_cycle_graph.dart';
14-
export 'library_cycle_graph/library_cycle_graph_loader.dart';
15-
export 'library_cycle_graph/phased_asset_deps.dart';
16-
export 'library_cycle_graph/phased_reader.dart';
17-
export 'library_cycle_graph/phased_value.dart';
18-
export 'state/asset_finder.dart';
19-
export 'state/asset_path_provider.dart';
20-
export 'state/filesystem.dart';
21-
export 'state/filesystem_cache.dart';
22-
export 'state/generated_asset_hider.dart';
23-
export 'state/reader_state.dart';
24-
export 'state/reader_writer.dart';

build_resolvers/lib/src/analysis_driver_model.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import 'dart:async';
77
// ignore: implementation_imports
88
import 'package:analyzer/src/clients/build_resolvers/build_resolvers.dart';
99
import 'package:build/build.dart';
10-
// ignore: implementation_imports
11-
import 'package:build/src/internal.dart';
1210
import 'package:build_runner_core/build_runner_core.dart';
1311
// ignore: implementation_imports
1412
import 'package:build_runner_core/src/generate/build_step_impl.dart';

build_runner/lib/src/watcher/change_filter.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import 'dart:async';
55

66
import 'package:build/build.dart';
7-
// ignore: implementation_imports
8-
import 'package:build/src/internal.dart';
97
import 'package:build_runner_core/build_runner_core.dart';
108
// ignore: implementation_imports
119
import 'package:build_runner_core/src/asset_graph/graph.dart';

build_runner_core/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
## 9.3.1-wip
22

3+
- Move `runBuilder` to here from `package:build`. Please note that all of
4+
`build_runner_core` is intended to be internal to `build_runner`: the
5+
supported ways to run builders are `build_runner` on the command line and
6+
`build_test` in tests. If you need ongoing support for a different way to run
7+
builders please get in touch at
8+
https://github.com/dart-lang/build/discussions.
39
- Use `build_runner` 2.7.1.
410
- Remove `overrideGeneratedOutputDirectory`, `pubBinary`.
511

build_runner_core/lib/build_runner_core.dart

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,13 @@ export 'src/generate/exceptions.dart'
1717
BuildScriptChangedException,
1818
CannotBuildException;
1919
export 'src/generate/finalized_assets_view.dart' show FinalizedAssetsView;
20+
export 'src/generate/input_tracker.dart';
2021
export 'src/generate/performance_tracker.dart'
2122
show BuildPerformance, BuildPhasePerformance, BuilderActionPerformance;
23+
export 'src/generate/run_builder.dart';
24+
export 'src/library_cycle_graph/asset_deps_loader.dart';
25+
export 'src/library_cycle_graph/library_cycle_graph_loader.dart';
26+
export 'src/library_cycle_graph/phased_asset_deps.dart';
2227
export 'src/logging/build_log.dart';
2328
export 'src/logging/build_log_configuration.dart';
2429
export 'src/logging/build_log_logger.dart';
@@ -40,6 +45,12 @@ export 'src/package_graph/apply_builders.dart'
4045
export 'src/package_graph/apply_builders.dart';
4146
export 'src/package_graph/package_graph.dart';
4247
export 'src/package_graph/target_graph.dart';
48+
export 'src/state/asset_finder.dart';
49+
export 'src/state/asset_path_provider.dart';
50+
export 'src/state/filesystem.dart';
51+
export 'src/state/filesystem_cache.dart';
52+
export 'src/state/generated_asset_hider.dart';
53+
export 'src/state/reader_state.dart';
4354
export 'src/util/constants.dart'
4455
show
4556
assetGraphPath,

build_runner_core/lib/src/asset/finalized_reader.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import 'dart:convert';
77

88
import 'package:build/build.dart';
99
// ignore: implementation_imports
10-
import 'package:build/src/internal.dart';
11-
// ignore: implementation_imports
1210
import 'package:build_runner/src/internal.dart';
1311
import 'package:built_collection/built_collection.dart';
1412
import 'package:crypto/crypto.dart';
@@ -19,6 +17,7 @@ import '../asset_graph/node.dart';
1917
import '../asset_graph/optional_output_tracker.dart';
2018
import '../generate/build_phases.dart';
2119
import '../package_graph/target_graph.dart';
20+
import '../state/asset_finder.dart';
2221

2322
/// A view of the build output.
2423
///

build_runner_core/lib/src/asset/reader_writer.dart

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,19 @@ import 'dart:convert';
66
import 'dart:io';
77

88
import 'package:build/build.dart';
9-
// ignore: implementation_imports
10-
import 'package:build/src/internal.dart';
119
import 'package:glob/glob.dart';
1210
import 'package:glob/list_local_fs.dart';
1311
import 'package:path/path.dart' as path;
1412

1513
import '../logging/timed_activities.dart';
1614
import '../package_graph/package_graph.dart';
15+
import '../state/asset_finder.dart';
16+
import '../state/asset_path_provider.dart';
17+
import '../state/filesystem.dart';
18+
import '../state/filesystem_cache.dart';
19+
import '../state/generated_asset_hider.dart';
20+
import '../state/reader_state.dart';
21+
import '../state/reader_writer.dart';
1722
import '../util/constants.dart';
1823
import 'writer.dart';
1924

build_runner_core/lib/src/asset_graph/graph.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import 'dart:io';
88

99
import 'package:build/build.dart';
1010
import 'package:build/experiments.dart' as experiments_zone;
11-
// ignore: implementation_imports
12-
import 'package:build/src/internal.dart';
1311
import 'package:built_collection/built_collection.dart';
1412
import 'package:built_value/serializer.dart';
1513
import 'package:crypto/crypto.dart';
@@ -20,7 +18,9 @@ import 'package:watcher/watcher.dart';
2018
import '../asset/writer.dart';
2119
import '../generate/build_phases.dart';
2220
import '../generate/phase.dart';
21+
import '../library_cycle_graph/phased_asset_deps.dart';
2322
import '../package_graph/package_graph.dart';
23+
import '../state/generated_asset_hider.dart';
2424
import '../util/constants.dart';
2525
import 'exceptions.dart';
2626
import 'node.dart';

0 commit comments

Comments
 (0)