Remove package:test version check. (#4163)

Author: davidmorgan

build_runner/CHANGELOG.md

@@ -6,6 +6,7 @@
 - Remove undocumented / unused features: `lib/build_script_generate.dart`,
   `bin/graph_inspector.dart`, `build_runner doctor` and
   `build_runner generate-build-script` commands.
+- Remove deps on `pubspec_parse` and `timing`.
 
 ## 2.7.0
 

build_runner/lib/src/entrypoint/runner.dart

@@ -34,7 +34,7 @@ class BuildCommandRunner extends CommandRunner<int> {
     addCommand(DaemonCommand());
     addCommand(RunCommand());
     addCommand(ServeCommand());
-    addCommand(TestCommand(packageGraph));
+    addCommand(TestCommand());
     addCommand(WatchCommand());
   }
 

build_runner/lib/src/entrypoint/test.dart

@@ -10,9 +10,6 @@ import 'package:async/async.dart';
 import 'package:build/experiments.dart';
 import 'package:build_runner_core/build_runner_core.dart';
 import 'package:io/io.dart';
-import 'package:path/path.dart' as p;
-import 'package:pub_semver/pub_semver.dart';
-import 'package:pubspec_parse/pubspec_parse.dart';
 
 import '../build_script_generate/build_process_state.dart';
 import '../generate/build.dart';
@@ -22,12 +19,7 @@ import 'options.dart';
 /// A command that does a single build and then runs tests using the compiled
 /// assets.
 class TestCommand extends BuildRunnerCommand {
-  TestCommand(PackageGraph packageGraph)
-    : super(
-        // Use symlinks by default, if package:test supports it.
-        symlinksDefault:
-            _packageTestSupportsSymlinks(packageGraph) && !Platform.isWindows,
-      );
+  TestCommand() : super(symlinksDefault: !Platform.isWindows);
 
   @override
   String get invocation =>
@@ -169,15 +161,6 @@ class TestCommand extends BuildRunnerCommand {
   }
 }
 
-bool _packageTestSupportsSymlinks(PackageGraph packageGraph) {
-  var testPackage = packageGraph['test'];
-  if (testPackage == null) return false;
-  var pubspecPath = p.join(testPackage.path, 'pubspec.yaml');
-  var pubspec = Pubspec.parse(File(pubspecPath).readAsStringSync());
-  if (pubspec.version == null) return false;
-  return pubspec.version! >= Version(1, 3, 0);
-}
-
 void _ensureBuildTestDependency(PackageGraph packageGraph) {
   if (!packageGraph.allPackages.containsKey('build_test')) {
     throw _BuildTestDependencyError();

build_runner/pubspec.yaml

@@ -31,12 +31,10 @@ dependencies:
   mime: '>=1.0.0 <3.0.0'
   path: ^1.8.0
   pub_semver: ^2.0.0
-  pubspec_parse: ^1.0.0
   shelf: ^1.0.0
   shelf_web_socket: ">=1.0.0 <4.0.0"
   stack_trace: ^1.10.0
   stream_transform: ^2.0.0
-  timing: ^1.0.0
   watcher: ^1.0.0
   web_socket_channel: ">=2.3.0 <4.0.0"