Skip to content

Commit b3eb1dc

Browse files
authored
Skip tests with Chrome on Windows. (#4169)
1 parent ca783ab commit b3eb1dc

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

_test/test/common/utils.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,8 @@ Future<void> expectTestsFail({
213213
List<String>? buildArgs,
214214
List<String>? testArgs,
215215
}) async {
216+
// Skip on Windows due to Chrome test flakiness, see
217+
// https://github.com/dart-lang/build/issues/4123.
216218
var result = await runTests(
217219
usePrecompiled: usePrecompiled,
218220
buildArgs: buildArgs,

_test/test/test_integration_test.dart

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
@TestOn('vm')
66
library;
77

8+
import 'dart:io';
9+
810
import 'package:io/io.dart';
911
import 'package:path/path.dart' as p;
1012
import 'package:test/test.dart';
@@ -36,6 +38,9 @@ void main() {
3638
);
3739

3840
test('Failing tests print mapped stack traces', () async {
41+
// Skip on Windows due to Chrome test flakiness, see
42+
// https://github.com/dart-lang/build/issues/4123.
43+
if (Platform.isWindows) return;
3944
var result = await runTests(
4045
testArgs: ['--run-skipped', 'test/hello_world_test.dart'],
4146
);

0 commit comments

Comments
 (0)