Remove unused field, fix LruCache.

Author: davidmorgan

build/lib/src/library_cycle_graph/library_cycle_graph_loader.dart

@@ -73,8 +73,6 @@ class LibraryCycleGraphLoader {
   /// for its sorting, so earlier phases are processed first in [_nextIdToLoad].
   final SplayTreeMap<int, List<AssetId>> _idsToLoad = SplayTreeMap();
 
-  final List<(int, AssetId)> _loadingIds = [];
-
   /// All loaded library cycles, by asset.
   final Map<AssetId, PhasedValue<LibraryCycle>> _cycles = {};
 
@@ -136,7 +134,6 @@ class LibraryCycleGraphLoader {
     // Return the last ID from the list of IDs at this phase because it's
     // cheapest to remove in `_removeIdToLoad`.
     final result = first.value.last;
-    _loadingIds.add((first.key, result));
     return (first.key, result);
   }
 

build/lib/src/state/lru_cache.dart

@@ -55,13 +55,15 @@ class LruCache<K, V> {
     _currentWeightTotal -= entry.weight;
     _entries.remove(key);
 
+    // Remove from linked list.
+    entry.previous?.next = entry.next;
+    entry.next?.previous = entry.previous;
+
     if (entry == _tail) {
       _tail = entry.next;
-      _tail?.previous = null;
     }
     if (entry == _head) {
       _head = entry.previous;
-      _head?.next = null;
     }
 
     return entry.value;
@@ -75,12 +77,9 @@ class LruCache<K, V> {
       _tail = link.next;
     }
 
-    if (link.previous != null) {
-      link.previous!.next = link.next;
-    }
-    if (link.next != null) {
-      link.next!.previous = link.previous;
-    }
+    // Remove from linked list.
+    link.previous?.next = link.next;
+    link.next?.previous = link.previous;
 
     _head?.next = link;
     link.previous = _head;

tool/leak_check.sh

@@ -14,9 +14,9 @@ fi
 dart test/invalidation/invalidation_leak_checker.dart setup
 
 leak_amount=$(dart test/invalidation/invalidation_leak_checker.dart)
-leak_limit=60000
+leak_limit=15000
 
-if test $((leak_amount)) -gt 60000; then
+if test $((leak_amount)) -gt "$leak_limit"; then
   echo "Measured leak size $leak_amount > $leak_limit, failing!"
   exit 1
 else
@@ -30,4 +30,7 @@ fi
 #   52455, 52332, 52308
 #
 # Initial check-in with https://dart-review.googlesource.com/c/sdk/+/441740:
-#  21482, 11568, 13186
+#   21482, 11568, 13186
+#
+# After `build_runner` leak fixes and analyzer 7.7.1 with 441740:
+#   13147, 12515, 13320