Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the constraints on shelf dependency #2983

Closed
nickmeinhold opened this issue Jan 30, 2021 · 1 comment · Fixed by #2986
Closed

Expand the constraints on shelf dependency #2983

nickmeinhold opened this issue Jan 30, 2021 · 1 comment · Fixed by #2986
Assignees
@jakemac53
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:build_daemon package:build_runner

Comments

@nickmeinhold
Copy link

I believe recent migration of http and shelf puts us in the situation described in this comment where we can't migrate a package that depends on both build_runner and http/shelf.

@jakemac53 you mentioned that it might be possible to expand build_runner's dependency constraints - is it possible to do so for shelf?

Thanks heaps!
@kevmoo kevmoo added package:build_daemon package:build_runner P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jan 30, 2021
@kevmoo
Copy link
Member

kevmoo commented Jan 30, 2021

@jakemac53 and @natebosch – when you get a chance!

@kevmoo kevmoo mentioned this issue Jan 30, 2021
Merged
@jakemac53 jakemac53 self-assigned this Feb 1, 2021
@jakemac53 jakemac53 mentioned this issue Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures package:build_daemon package:build_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow the null safety releases of several packages dart-lang/build
3 participants
@kevmoo @jakemac53 @nickmeinhold