-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method of recognizing generated files #34
Labels
type-enhancement
A request for a change that isn't a bug
Milestone
Comments
cc @kegluneq @nex3 @munificent please review proposed solution. This should mean we don't need to require any specific file extensions in order to discover which files are generated files. |
cc @kevmoo as well |
I like this idea better than the other solutions we've discussed. |
👍 I like that this dovetails well with on-disk caching of derived information. |
Done |
kevmoo
added
type-enhancement
A request for a change that isn't a bug
and removed
enhancement
labels
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After a build, the next build needs to know which files were generated previously, so that they aren't treated as inputs.
Proposed solution:
Output a
build_outputs.json
file under a new hidden folder.build
, eventually this will be replaced by the dependency graph file, but for now it will just be a list of all output file ids. Just using JSON for now as its the easiest, eventually more formats need to be evaluated.On startup, check if the file exists and:
declareOutputs
on all builders in all phases, recording all declared outputs which would conflict with an existing file on disk. If there are conflicts then summarize the results to the user to confirm deletion of these files, and then start over.The text was updated successfully, but these errors were encountered: