Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make BuildOptions immutable #95

Closed
kevmoo opened this issue Mar 16, 2016 · 1 comment
Closed

make BuildOptions immutable #95

kevmoo opened this issue Mar 16, 2016 · 1 comment
Labels
P3 A lower priority bug or feature request package:build_runner type-enhancement A request for a change that isn't a bug

Comments

@kevmoo
Copy link
Member

kevmoo commented Mar 16, 2016

It just...hurts
@jakemac53
Copy link
Contributor

I was thinking about exposing this at the top level as well, and splitting it into BuildOptions, WatchOptions, and ServeOptions. Then we could supply a fromArgs constructor as well to support some standard command line args.

This would be a breaking change but would greatly simplify the method signatures and reduce a lot of duplicate named args across the different top level methods.

@jakemac53 jakemac53 added this to the 0.3.0 milestone Mar 18, 2016
@jakemac53 jakemac53 removed this from the 0.3.0 milestone Jan 13, 2017
@jakemac53 jakemac53 added P3 A lower priority bug or feature request package:build_runner S3 low type-enhancement A request for a change that isn't a bug labels Jan 30, 2017
@matanlurey matanlurey self-assigned this Oct 5, 2017
@matanlurey matanlurey mentioned this issue Oct 5, 2017
Closed
@matanlurey matanlurey removed their assignment Nov 6, 2017
@natebosch natebosch mentioned this issue Dec 25, 2017
Merged
@jakemac53 jakemac53 mentioned this issue Feb 14, 2018
Merged
@vsmenon vsmenon mentioned this issue Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request package:build_runner type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @matanlurey @jakemac53