Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Class modifiers] Remove use of classes as mixins #1875

Closed
mit-mit opened this issue Feb 21, 2023 · 5 comments
Closed

[Class modifiers] Remove use of classes as mixins #1875

mit-mit opened this issue Feb 21, 2023 · 5 comments
Assignees

Comments

@mit-mit
Copy link
Member

mit-mit commented Feb 21, 2023

Pre-Dart 3 any class can be used as a mixin. In Dart 3, only mixin class foo (a declaration that defines both a class and a mixin.) and mixin foo are allowed:
dart-lang/language#1643
https://github.com/dart-lang/language/blob/master/accepted/future-releases/class-modifiers/feature-specification.md

There seems to be a bunch of classes in co19 that use classes as mixins, from this test run:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8788634602419351857/+/u/test_results/new_test_failures__logs_

Can we get those updated?

cc @lrhn

@mit-mit mit-mit changed the title Remove use of classes as mixins [Class modifiers] Remove use of classes as mixins Feb 21, 2023
@sgrekhov
Copy link
Contributor

@mit-mit please provide a link to the Gerrit changelist

@lrhn
Copy link
Member

lrhn commented Feb 21, 2023

The CL which should (when it successfully lands) enable this is https://dart-review.googlesource.com/c/sdk/+/284304

If CFE/analyzer actually implements it correctly, there might be some tweaks needed, if they don't actually look at the Function declaration.

@sgrekhov sgrekhov self-assigned this Feb 21, 2023
@mit-mit
Copy link
Member Author

mit-mit commented Feb 22, 2023

The mentioned changelist is the same as mentioned in #1874 (comment)

@sgrekhov
Copy link
Contributor

If you don't mind I'll fix if when CL is landed

@sgrekhov
Copy link
Contributor

sgrekhov commented Mar 7, 2023

#1907 added // @dart=2.19 to all legacy mixin tests. I believe this fixed this issue. Closing it

@sgrekhov sgrekhov closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants