-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Class modifiers] Remove use of classes as mixins #1875
Comments
@mit-mit please provide a link to the Gerrit changelist |
The CL which should (when it successfully lands) enable this is https://dart-review.googlesource.com/c/sdk/+/284304 If CFE/analyzer actually implements it correctly, there might be some tweaks needed, if they don't actually look at the |
The mentioned changelist is the same as mentioned in #1874 (comment) |
If you don't mind I'll fix if when CL is landed |
#1907 added |
Pre-Dart 3 any class can be used as a mixin. In Dart 3, only
mixin class foo
(a declaration that defines both a class and a mixin.) andmixin foo
are allowed:dart-lang/language#1643
https://github.com/dart-lang/language/blob/master/accepted/future-releases/class-modifiers/feature-specification.md
There seems to be a bunch of classes in co19 that use classes as mixins, from this test run:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8788634602419351857/+/u/test_results/new_test_failures__logs_
Can we get those updated?
cc @lrhn
The text was updated successfully, but these errors were encountered: