This repository has been archived by the owner on Oct 17, 2024. It is now read-only.
Add chunked decoding support to CodePage #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add chunked decoding support (`startChunkedConversion`) for `CodePage` encodings
lrhn
reviewed
Nov 4, 2023
lrhn
approved these changes
Nov 6, 2023
| }); | ||
|
|
||
| test('chunked conversion', () { | ||
| late final String decodedString; |
There was a problem hiding this comment.
Just initialize it to "" instead of being late. (I don't like late 😉 )
There was a problem hiding this comment.
I don't like mutability ;-) I'd prefer to have late and make it final rather lose the final specifier ;-)
test/codepage_test.dart
Outdated
| group('Custom code page', () { | ||
| late final CodePage cp; | ||
|
|
||
| setUpAll(() => cp = CodePage('custom', "ABCDEF${"\uFFFD" * 250}")); |
There was a problem hiding this comment.
Code pages should be immutable, so just initialize it directly, without using setUp. (I also don't like setUp 😁).
Unless you fear that it will throw?
(What's the difference between setUp and setUpAll?)
There was a problem hiding this comment.
setUp runs for each embedded test, setUpAll runs once.
Done.
|
FYI, I changed the minimum supported SDK version to 3.0 to get the |
mosuem
pushed a commit
to dart-lang/core
that referenced
this pull request
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startChunkedConversion) forCodePageencodings. This is straightforward becauseCodePageencodings map a single byte to set of code units so state must be preserved between chunks.Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.