-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc links don't work #339
Comments
This has already been fixed in dart-archive/async#158, I think we just need to publish. |
@natebosch, I think 376c0fe95fa6fe7a5a6c41ef7b4585085c826f89 has rolling into the SDK and google3, are we good to publish it now? |
@jonasfj - I think it is worth exploring the idea proposed in dart-archive/async#161 (comment) first |
@jonasfj Is this a major change? Then I think I can remove the part in the dart-lang/site-www#3147 that refers to the async package and update it later. |
@natebosch, I think there are many reasons we shouldn't pursue |
Yeah I think we can keep the reader as is. |
Looks like the links are working now. 🎉 |
In the package page (https://pub.dev/packages/async), the API doc homepage (https://pub.dev/documentation/async/latest/), and the repo homepage (https://github.com/dart-lang/async#readme), links to the generated API doc don't work.
They go to URLs like this:
https://pub.dev/documentation/async/latest/async/AsyncCache-class.html
But the published doc's URLs are like this:
https://pub.dev/documentation/async/latest/pkg.async/AsyncCache-class.html
Which makes me wonder: did you really mean to change the library name from async to pkg.async? If so, editing the README is all that's necessary to fix this. If not...
The text was updated successfully, but these errors were encountered: