Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 100+ skipped tests in this package #587

Closed
matanlurey opened this issue Mar 12, 2018 · 0 comments · Fixed by dart-archive/collection#83
Closed

Enable 100+ skipped tests in this package #587

matanlurey opened this issue Mar 12, 2018 · 0 comments · Fixed by dart-archive/collection#83
Assignees
@matanlurey
Labels
package:collection type-enhancement A request for a change that isn't a bug

Comments

@matanlurey
Copy link
Contributor

It looks like we will need to run the tests using DDC, and skip them for Dart2JS only until Dart2JS implements 2.0 semantics. Seems easy enough, we've done that in other places.
@matanlurey matanlurey added the type-enhancement A request for a change that isn't a bug label Mar 12, 2018
@matanlurey matanlurey self-assigned this Mar 12, 2018
@matanlurey matanlurey mentioned this issue Mar 12, 2018
Merged
@mosuem mosuem transferred this issue from dart-archive/collection Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matanlurey matanlurey

Labels
package:collection type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add DDC test coverage, enable skipped tests. matanlurey/collection
2 participants
@matanlurey @mosuem