Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support determining the page_width given a list / lists of multiple included files #1591

Closed
srawlins opened this issue Oct 30, 2024 · 3 comments · Fixed by #1594
Closed

Support determining the page_width given a list / lists of multiple included files #1591

srawlins opened this issue Oct 30, 2024 · 3 comments · Fixed by #1594
Assignees

Comments

@srawlins
Copy link
Member

For dart-lang/sdk#47256, the analyzer recently supports merging multiple include files, in an analysis options file. So before we only supported:

include: some_file.yaml

and we now additionally support:

include:
  - one_file.yaml
  - ../../another.yaml
  - package:foo/thrid.yaml

I believe this package has it's own YAML merging logic to read the single (chain of) include files.

@srawlins
Copy link
Member Author

Notes for whoever implements this in dart_style:

@srawlins
Copy link
Member Author

@munificent would you mind if I took a whack at this?

@munificent
Copy link
Member

I was honestly surprised when I first implemented this that only a single include was supported.

@munificent would you mind if I took a whack at this?

Sure, not at all! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants